lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Fattens the 256 first braces. (issue4518052)


From: dak
Subject: Re: Fattens the 256 first braces. (issue4518052)
Date: Wed, 11 May 2011 09:54:36 +0000

On 2011/05/11 09:22:14, Bertrand Bordage wrote:
http://codereview.appspot.com/4518052/diff/2002/mf/feta-braces.mf
File mf/feta-braces.mf (right):


http://codereview.appspot.com/4518052/diff/2002/mf/feta-braces.mf#newcode151
mf/feta-braces.mf:151: fatten := 1 + fatten_factor - min ( number *
fatten_factor / 256, fatten_factor);
Thanks !
Hum...
I agree with your idea of making this clearer.
I also agree that my factor isn't really a factor since it's neutral
value is 0.
But the functions you gave do not produce the correct output.
And I can't manage to find something cleaner than what I wrote.
Also : we can't get rid of "fatten", as it is also used to thicken the
ends of
the braces.

Well, the middle formula was missing parens around number/256.  Other
than that, it should have worked fine.

Something like
fatten := min(number/256,1)[1+fatten_factor,1];
should do the trick then.

http://codereview.appspot.com/4518052/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]