Re: Doc: NR 1.6.3 - edit eg.s in quoting other voices (issue4518053)

[pkx166h]

Reviewers: Graham Percival, Keith,

Message:
Second Draft


http://codereview.appspot.com/4518053/diff/1/Documentation/notation/staff.itely
File Documentation/notation/staff.itely (right):

http://codereview.appspot.com/4518053/diff/1/Documentation/notation/staff.itely#newcode1022
Documentation/notation/staff.itely:1022: @cindex quote, voices
On 2011/05/10 19:59:35, Graham Percival wrote:
> could we keep the old @cindex as well?  I'm fine with adding the new
ones; just
> don't remove the old ones.

I didn't remove as much as reword for clarity. Else we get into
semantics about (for example) cues vs cue notes (cues means nothing -
snooker cues? 'cue notes' is what they are properly called). Again
'Fragments' is meaningless in an index without some context - which I
added (Fragments, quoting).

http://codereview.appspot.com/4518053/diff/1/Documentation/notation/staff.itely#newcode1045
Documentation/notation/staff.itely:1045: \addQuote "flute" @{
\fluteNotes @}
On 2011/05/11 03:26:40, Keith wrote:
> > remove the @example and just go directly into the @lilypond.

> That would be better.

Done.

http://codereview.appspot.com/4518053/diff/1/Documentation/notation/staff.itely#newcode1045
Documentation/notation/staff.itely:1045: \addQuote "flute" @{
\fluteNotes @}
On 2011/05/10 19:59:35, Graham Percival wrote:
> could we keep a definition for \fluteNotes ?  again, I'm happy to have
the name
> change, but I'd like to see some notes actually being defined.

> alternately, remove the @example and just go directly into the
@lilypond.  That
> would be my first instinct, actually, although I can't claim to have
looked at
> this in detail.

Done.

http://codereview.appspot.com/4518053/diff/1/Documentation/notation/staff.itely#newcode1072
Documentation/notation/staff.itely:1072: If the music expression used in
@code{\quoteDuring} contains notes
On 2011/05/11 03:26:40, Keith wrote:
> I suggest removing this whole paragraph and @lilypond.
> 1. The original text was wrong: \quoteDuring does not create another
Voice for
> polyphony; instead it adds notes to the existing Voice to make chords.
> 2. Using \cueDuring, by contrast, *does* add a voice and create a
polyphonic
> situation, and in fact I have found that to be useful, but was
discouraged from
> trying it because of the old text.

I think we need something, somewhere about this, as it would appear that
this is a nice way to add polyphony - even if it isn't and to be honest
I don't know what the difference is, or the subtlety is lost on me. It
LOOKS like polyphony.

Maybe an appropriate @KNOWNISSUE?

http://codereview.appspot.com/4518053/diff/1/Documentation/notation/staff.itely#newcode1082
Documentation/notation/staff.itely:1082: c4 cis c b \quoteDuring
#"flute" { e4 dis b a }
On 2011/05/11 03:26:40, Keith wrote:
>    c4 cis c b \quoteDuring #"flute" { e4 r8 ais b4 a }
> If you do decide to keep this @lilypond, at least make it output
something
> sensible.

Kept it in for now until we decide on the last comment.

http://codereview.appspot.com/4518053/diff/1/Documentation/notation/staff.itely#newcode1101
Documentation/notation/staff.itely:1101: a4 gis g gis | b4^"quoted" r8
ais\p a4( f)
On 2011/05/11 03:26:40, Keith wrote:
>    \key d\major
>    b4 ais a ais | cis4^"quoted" r8 bis\p b4( f)
> so that this example realistically shows the same concert-pitch notes
as the
> earlier examples.
> (I should have caught this error months ago.)

Done.

http://codereview.appspot.com/4518053/diff/1/Documentation/notation/staff.itely#newcode1120
Documentation/notation/staff.itely:1120: markups, etc. and is inserted
into the music expression.  It is possible
On 2011/05/11 03:26:40, Keith wrote:
> markups, etc. --[and is inserted into the music expression]--

Not sure what you wanted here, but I have improved this awkward sentence
anyway.

Description:
Doc: NR 1.6.3 - edit eg.s in quoting other voices

Suggestion from Keith O'Hara.

An attempt to give a more realistic example than what was previously
there.

It also helps emphasise that it must be made at the top level but also
that the
order of the \quoteDurings and \addQuotes is not prescribed.

Minor improvements of syntax and I moved around some of the information
to make it flow more easily. Removed unnecessary text (either redundant,
repeated or shown in the example).

Please review this at http://codereview.appspot.com/4518053/

Affected files:
  M Documentation/notation/staff.itely