[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Making website build almost completely quiet (issue4515042)
From: |
percival . music . ca |
Subject: |
Re: Making website build almost completely quiet (issue4515042) |
Date: |
Sun, 15 May 2011 20:19:52 +0000 |
could we get a subject like "add a -q quiet flag to make websit scripts"
?
Also, don't mention that it includes previous patches -- that's
implicitly done everywhere in git (or any source versioning system)
http://codereview.appspot.com/4515042/diff/10001/make/website.make
File make/website.make (right):
http://codereview.appspot.com/4515042/diff/10001/make/website.make#newcode7
make/website.make:7:
IMO this stuff isn't security -- could you move it elsewhere in the
file?
Also, could you move the quiet-run = true up so that it's in the same
"paragraph" as the commented-out stuff? Logically, setting
quiet-run=true is a separate stage from the quiet-flag.
http://codereview.appspot.com/4515042/diff/10001/scripts/build/bib2texi.py
File scripts/build/bib2texi.py (right):
http://codereview.appspot.com/4515042/diff/10001/scripts/build/bib2texi.py#newcode63
scripts/build/bib2texi.py:63: quiet_flag = ''
the lilypond python style is to use 4 spaces per indent.
http://codereview.appspot.com/4515042/
- Re: Making website build almost completely quiet (issue4515042), percival . music . ca, 2011/05/11
- Re: Making website build almost completely quiet (issue4515042), PhilEHolmes, 2011/05/14
- Re: Making website build almost completely quiet (issue4515042), percival . music . ca, 2011/05/15
- Re: Making website build almost completely quiet (issue4515042), percival . music . ca, 2011/05/15
- Re: Making website build almost completely quiet (issue4515042), PhilEHolmes, 2011/05/15
- Re: Making website build almost completely quiet (issue4515042),
percival . music . ca <=
- Re: Making website build almost completely quiet (issue4515042), PhilEHolmes, 2011/05/25
- Re: Making website build almost completely quiet (issue4515042), percival . music . ca, 2011/05/25