Re: Emit not-quite-cross-staff beams in the right context. (issue4564041)

[address@hidden]

On May 31, 2011, at 9:19 AM, address@hidden wrote:

> Reviewers: Keith,
> 
> Message:
> On 2011/05/28 18:43:19, Keith wrote:
>> I would love to test, but don't know enough of the internals to see
> what this
>> does.
> 
> If you take your example from comment 5 of issue 1043, without manual
> beaming, the Beam's Y-parent will be the VerticalAxisGroup of the top
> staff and Beam::calc_cross_staff will return true. With manual beaming
> (or with this patch), the Beam's Y-parent will be the VerticalAxisGroup
> of the bottom staff and Beam::calc_cross_staff will return false.
> 
> 
> Description:
> Emit not-quite-cross-staff beams in the right context.
> 
> This is related to 1043 and possibly other bugs.  Previously,
> if a staff change happened immediately after the termination of
> an auto-engraved cross-staff beam, then the beam was parented
> to the wrong staff.  Now, every beam is parented to the context
> in which it began.
> 

Hey Joe,

Lines 1207-1209 in beam.cc are a kludge that I believe your patch resolves.  
You may want to consider removing these lines and testing to see if it still 
passes regtests.  If so, I think you can nix these lines permanently.

Cheers,
MS