lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Bugfix for issue 1630 (issue4490045)


From: n . puttock
Subject: Re: Bugfix for issue 1630 (issue4490045)
Date: Wed, 01 Jun 2011 21:21:25 +0000

LGTM.


http://codereview.appspot.com/4490045/diff/20001/lily/completion-note-heads-engraver.cc
File lily/completion-note-heads-engraver.cc (right):

http://codereview.appspot.com/4490045/diff/20001/lily/completion-note-heads-engraver.cc#newcode204
lily/completion-note-heads-engraver.cc:204:
event->set_property("autosplit-end",
set_property (

http://codereview.appspot.com/4490045/diff/20001/lily/completion-note-heads-engraver.cc#newcode205
lily/completion-note-heads-engraver.cc:205: ly_bool2scm (left_to_do_ -
note_dur.get_length () > Rational (0)));
indent:

event->set_property ("autosplit-end",
                     ly_bool2scm (

http://codereview.appspot.com/4490045/diff/20001/lily/tie-engraver.cc
File lily/tie-engraver.cc (right):

http://codereview.appspot.com/4490045/diff/20001/lily/tie-engraver.cc#newcode85
lily/tie-engraver.cc:85: bool has_autosplit_end (Stream_event* event);
Stream_event *event

http://codereview.appspot.com/4490045/diff/20001/lily/tie-engraver.cc#newcode125
lily/tie-engraver.cc:125: Tie_engraver::has_autosplit_end (Stream_event*
event)
Stream_event *event

http://codereview.appspot.com/4490045/diff/20001/lily/tie-engraver.cc#newcode163
lily/tie-engraver.cc:163: /*
indent

http://codereview.appspot.com/4490045/diff/20001/lily/tie-engraver.cc#newcode289
lily/tie-engraver.cc:289: if (left_ev && (tie_event || tie_stream_event)
indent

http://codereview.appspot.com/4490045/diff/20001/scm/define-music-properties.scm
File scm/define-music-properties.scm (right):

http://codereview.appspot.com/4490045/diff/20001/scm/define-music-properties.scm#newcode44
scm/define-music-properties.scm:44: (autosplit-end ,boolean? "Duration
of event was truncated by automatic splitting in
Completion_heads_engraver.")
the @code{Completion_heads_engraver}.

http://codereview.appspot.com/4490045/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]