[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Makes outside-staff-property work for TupletNumber. (issue4530112)
|
From: |
address@hidden |
|
Subject: |
Re: Makes outside-staff-property work for TupletNumber. (issue4530112) |
|
Date: |
Mon, 13 Jun 2011 13:34:54 +0200 |
On Jun 12, 2011, at 6:52 PM, address@hidden wrote:
> LGTM.
>
>
> http://codereview.appspot.com/4530112/diff/1/scm/define-grobs.scm
> File scm/define-grobs.scm (right):
>
> http://codereview.appspot.com/4530112/diff/1/scm/define-grobs.scm#newcode2344
> scm/define-grobs.scm:2344: (direction . ,tuplet-number::calc-direction)
> add `direction' to tuplet-number.cc for documentation
>
> http://codereview.appspot.com/4530112/diff/1/scm/output-lib.scm
> File scm/output-lib.scm (right):
>
> http://codereview.appspot.com/4530112/diff/1/scm/output-lib.scm#newcode330
> scm/output-lib.scm:330: (define-public (tuplet-number::calc-direction
> grob)
> move above `tuplet-number::cacl-denominator-text'
Done. Passed regtests, so added a regtest & pushed.
b375521f6040ee5e894e80755e89f2b36795eb1a
Cheers,
MS