[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Bugfix for issue 1630 (issue4490045)
From: |
percival . music . ca |
Subject: |
Re: Bugfix for issue 1630 (issue4490045) |
Date: |
Wed, 15 Jun 2011 09:29:00 +0000 |
I've identified a few more questionable lines, although maybe you should
wait for a lilypond C++ expert to look at them.
Now do you see why I was apologizing so much for not starting the C++
GOP question this week? this stuff is ridiculous. :/
http://codereview.appspot.com/4490045/diff/35002/lily/tie-engraver.cc
File lily/tie-engraver.cc (right):
http://codereview.appspot.com/4490045/diff/35002/lily/tie-engraver.cc#newcode157
lily/tie-engraver.cc:157: maybe should check positions too.
this should be indented with:
1 tab
http://codereview.appspot.com/4490045/diff/35002/lily/tie-engraver.cc#newcode189
lily/tie-engraver.cc:189: /*
this should be indented with:
1 tab
http://codereview.appspot.com/4490045/diff/35002/lily/tie-engraver.cc#newcode190
lily/tie-engraver.cc:190: Prevent all other tied notes ending at the
same moment (assume
this should be indented with:
1 tab + 2 spaces
http://codereview.appspot.com/4490045/diff/35002/lily/tie-engraver.cc#newcode238
lily/tie-engraver.cc:238: {
heh, wow, the original file was wrong. Go figure.
(yes, this change is correct)
http://codereview.appspot.com/4490045/
Re: Bugfix for issue 1630 (issue4490045), karin . hoethker, 2011/06/15
Re: Bugfix for issue 1630 (issue4490045), percival . music . ca, 2011/06/15