lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Modifies Spanner::spanner_length to better handle line-spanners. (is


From: Colin Campbell
Subject: Re: Modifies Spanner::spanner_length to better handle line-spanners. (issue4621044)
Date: Thu, 16 Jun 2011 06:56:40 -0600
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110516 Lightning/1.0b2 Thunderbird/3.1.10

On 11-06-16 02:36 AM, address@hidden wrote:
On Jun 15, 2011, at 10:39 PM, address@hidden wrote:

LGTM.


http://codereview.appspot.com/4621044/diff/1/lily/spanner.cc
File lily/spanner.cc (right):

http://codereview.appspot.com/4621044/diff/1/lily/spanner.cc#newcode243
lily/spanner.cc:243:
whitespace

http://codereview.appspot.com/4621044/diff/1/lily/spanner.cc#newcode249
lily/spanner.cc:249: lr[d] = robust_scm2double (ly_assoc_get
(ly_symbol2scm ("X"),
indent:

do
  lr[d] = robust_scm2double (ly_assoc_get (ly_symbol2scm ("X"),

http://codereview.appspot.com/4621044/diff/1/lily/spanner.cc#newcode252
lily/spanner.cc:252:
whitespace

http://codereview.appspot.com/4621044/
Clean regtests, so changes made and pushed.
d02c9ba13cc3a7c96cc6374e232e94501a833ed1

Cheers,
MS



Would you update the status of your reitveld issue, please, which is still showing as "patch - new"? Thanks, Mike.

Colin Campbell
Bug Squad

--
A chief event of life is the day in which we have encountered a mind
that startled us.
 -Ralph Waldo Emerson, writer and philosopher (1803-1882)




reply via email to

[Prev in Thread] Current Thread [Next in Thread]