Re: New breve rest with ledger lines (issue4650052)

[k-ohara5a5a]

What is required to demonstrate this ?
I thought of
\relative c'' {
  \override Staff.NoteHead  #'style = #'mensural
  \override Staff.Rest  #'style = #'mensural
  \time 4/2
  << {
    g'1\rest b1\rest g\breve\rest b\breve\rest d\breve\rest
  } \\ {
    c,1 r2 r4 r4 r\breve r\breve r\breve
  } >>
}

but I don't see your new glyphs.

More importantly, the patch as it stands breaks breve rests outside the
staff for styles other than mensural (as if you remove the \overrides
above.)


http://codereview.appspot.com/4650052/diff/1/lily/rest.cc
File lily/rest.cc (right):

http://codereview.appspot.com/4650052/diff/1/lily/rest.cc#newcode83
lily/rest.cc:83: if (try_ledgers && (balltype == 0 || balltype == 1 ||
balltype == -1))
Less risk of future mistakes if you go in order: -1, 0, 1
and on lines 93-95 as well

http://codereview.appspot.com/4650052/diff/1/lily/rest.cc#newcode95
lily/rest.cc:95: is_ledgered |= (balltype == -1) && (pos <= -rad - 3 ||
pos >= +rad + 2);
Either   ...&& style == "mensual"
or below trap cases for which there is no rest in the font,
or best of all give us ledgered breve rests for the default style as
well

http://codereview.appspot.com/4650052/