[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: FiguredBass: Rewrite of the engraver to fix vertical position (issue
From: |
reinhold . kainhofer |
Subject: |
Re: FiguredBass: Rewrite of the engraver to fix vertical position (issue224052) |
Date: |
Sat, 25 Jun 2011 19:38:30 +0000 |
Reviewers: colinpkcampbell_gmail.com,
Message:
On 2011/06/25 19:31:00, Colin Campbell wrote:
Just tidying up a bit: has this been superceded by the fix to issue
1671?
No, that patch is for a totally unrelated problem, namely that for e.g.
<6> <3 6 9>
the 3 (and of course the 9) will be placed BELOW instead of above the
extender for the 7. I'll continue on that patch during the summer, since
I desparetely need it for a score I'm publishing...
Description:
FiguredBass: Rewrite of the engraver to fix vertical position
-) use list<..> instead of vector<..>
-) Don't reuse old figure storage and no longer simply fill in
empty positions, which causes ordering to be lost in some
extender cases.
-) Add description of engraver logic
Please review this at http://codereview.appspot.com/224052/
Affected files:
M input/regression/figured-bass-continuation-center.ly
A input/regression/figured-bass-figureorder-position.ly
A input/regression/figured-bass-figureorder.ly
M lily/figured-bass-engraver.cc