Re: Fixes error for tuplet bracket direction calculation when tuplets contain rests. (issue4668045)

[Han-Wen Nienhuys]

test missing.

On Wed, Jun 29, 2011 at 8:25 AM,  <address@hidden> wrote:
> Reviewers: ,
>
> Message:
> Cheers,
> MS
>
> Description:
> Fixes error for tuplet bracket direction calculation when tuplets
> contain rests.
>
> Please review this at http://codereview.appspot.com/4668045/
>
> Affected files:
>  M lily/tuplet-bracket.cc
>
>
> Index: lily/tuplet-bracket.cc
> diff --git a/lily/tuplet-bracket.cc b/lily/tuplet-bracket.cc
> index
> 3bf2d1b49e8487815b79d1ec8af0b89a526803b2..f09a3a8e093eebb3f7435abbe99a859c561689cc
> 100644
> --- a/lily/tuplet-bracket.cc
> +++ b/lily/tuplet-bracket.cc
> @@ -730,6 +730,8 @@ Tuplet_bracket::get_default_dir (Grob *me)
>   for (vsize i = 0; i < columns.size (); i++)
>     {
>       Grob *nc = columns[i];
> +      if (Note_column::has_rests (nc))
> +        continue;
>       Direction d = Note_column::dir (nc);
>       if (d)
>        dirs[d]++;
>
>
>
> _______________________________________________
> lilypond-devel mailing list
> address@hidden
> https://lists.gnu.org/mailman/listinfo/lilypond-devel
>



-- 
Han-Wen Nienhuys - address@hidden - http://www.xs4all.nl/~hanwen