lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Allows for rider grobs in outside-staff-priority. (issue4639075)


From: hanwenn
Subject: Re: Allows for rider grobs in outside-staff-priority. (issue4639075)
Date: Fri, 01 Jul 2011 15:02:58 +0000

This patch doesnt make sense to me.  The TupletBracket grob is already
linked to the TupletNumber.  The correct way to fix this is to make sure
the number lets the bracket decide its position.


http://codereview.appspot.com/4639075/diff/4001/lily/axis-group-interface.cc
File lily/axis-group-interface.cc (right):

http://codereview.appspot.com/4639075/diff/4001/lily/axis-group-interface.cc#newcode199
lily/axis-group-interface.cc:199: bool outside_staff_rider = unsmob_grob
(g->get_object ("outside-staff-carrier")) ? true : false;
what is a 'rider' ?  Are you sure we need another property for this?

http://codereview.appspot.com/4639075/diff/4001/lily/axis-group-interface.cc#newcode262
lily/axis-group-interface.cc:262: mid_line_heights[j].unite (
code dup. please fix

http://codereview.appspot.com/4639075/diff/4001/scm/define-grob-properties.scm
File scm/define-grob-properties.scm (right):

http://codereview.appspot.com/4639075/diff/4001/scm/define-grob-properties.scm#newcode1033
scm/define-grob-properties.scm:1033: outside the staff.")
how is this different from side-support-elements ?

the definition is unclear as well- what does it mean to "carry" ?

http://codereview.appspot.com/4639075/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]