[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Fix Issue 770: Lyrics attached to a voice-derived context are off by
From: |
Reinhold Kainhofer |
Subject: |
Re: Fix Issue 770: Lyrics attached to a voice-derived context are off by 1 (issue4672041) |
Date: |
Fri, 8 Jul 2011 01:20:05 +0200 |
User-agent: |
KMail/1.13.6 (Linux/2.6.38-8-generic; KDE/4.6.4; i686; ; ) |
Am Donnerstag, 7. Juli 2011, 21:21:16 schrieben Sie:
> Hi Reinhold,
>
> This LGTM, but do you know why removing this code doesn't break the
> regtest added for issue 221 (lyric-combine-switch-voice.ly)?
AFAIU, the main change of Han-Wen's patch
(6a3360c40308285434e06a1de031efb073c015fa) was to listen for new voice
creation, even when a voice was already assigned. If associatedVoice was
changed, this allows to assign a new voice.
The check that I removed doesn't change this. It simply calls find_voice in
some more cases (i.e. when a non-Voice context is created), but if the
associatedVoice wasn't changed, at worst the original voice is found again or
no appropriate voice is found at all. In both cases, nothing really changes.
In the first case, we simply assign the same voice again and in the second
case, nothing happens at all. Similarly, if the associatedVoice was changed,
it will either find the new voice (even if some other context was created), or
not.
Cheers,
Reinhold
--
------------------------------------------------------------------
Reinhold Kainhofer, address@hidden, http://reinhold.kainhofer.com/
* Financial & Actuarial Math., Vienna Univ. of Technology, Austria
* http://www.fam.tuwien.ac.at/, DVR: 0005886
* LilyPond, Music typesetting, http://www.lilypond.org