lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Fixes note column skylines by adding stem tremolo to axis group. (is


From: n . puttock
Subject: Re: Fixes note column skylines by adding stem tremolo to axis group. (issue4754054)
Date: Mon, 18 Jul 2011 19:53:38 +0000

On 2011/07/18 19:47:53, Neil Puttock wrote:
On 2011/07/18 19:28:51, MikeSol wrote:

> How would pure height affect the calculation of horizontal skylines?

It should ensure the skylines are correct, assuming there's an entry
for
Stem_tremolo::height in pure-conversions-alist.

It looks like the existing height function is pure since it doesn't
reference
beams, so you just need to add the start/end arguments and a new
Stem_tremolo::height callback which gets the extent from the
translated stencil.

Even simpler: remove the Y-extent default, add Stem_tremolo::pure_height
and an entry in pure-print-to-height-conversions (since
ly:grob::stencil-height is the same as getting the non-pure extent from
the translated stencil).

http://codereview.appspot.com/4754054/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]