Re: Get rid of some compiler warnings (issue4854049)

[k-ohara5a5a]

Reinhold Kainhofer <reinhold <at> kainhofer.com> writes:
LGTM

> Am Freitag, 5. August 2011, 21:22:49 schrieb Keith OHara:

> > The entire source tree generates only seven warnings, all but one of
which
> > point to code we could write more clearly.

> Ah, great. Will you try to fix them?

You beat me to it :-)
I'll clean up the .ll, unless Neil has already done that.


http://codereview.appspot.com/4854049/diff/2001/lily/glissando-engraver.cc
File lily/glissando-engraver.cc (right):

http://codereview.appspot.com/4854049/diff/2001/lily/glissando-engraver.cc#newcode124
lily/glissando-engraver.cc:124: if (n1 < 0 || n2 < 0 || unsigned(n1) >=
note_heads.size ())
just confirming, that was what the compiler was doing, per the C++
standard.

http://codereview.appspot.com/4854049/diff/2001/lily/skyline.cc
File lily/skyline.cc (right):

http://codereview.appspot.com/4854049/diff/2001/lily/skyline.cc#newcode409
lily/skyline.cc:409: // FIXME: This has hardcoded logic, assuming a ==
AXIS_X!
 assert (AXIS_X == a);
instead?

http://codereview.appspot.com/4854049/diff/5001/lily/lyric-combine-music-iterator.cc
File lily/lyric-combine-music-iterator.cc (right):

http://codereview.appspot.com/4854049/diff/5001/lily/lyric-combine-music-iterator.cc#newcode224
lily/lyric-combine-music-iterator.cc:224:
Lyric_combine_music_iterator::check_new_context (SCM /*sev*/)
On 2011/08/09 21:20:29, Carl wrote:
> Why not /*SCM sev*/ with a FIXME?

the function is declared with DECLARE_LISTENTER so it has to take a
stream event, even if it doesn't use it.

http://codereview.appspot.com/4854049/