Re: Fix for Issue 620. (issue 4814041)

[n . puttock]

http://codereview.appspot.com/4814041/diff/24001/lily/axis-group-interface.cc
File lily/axis-group-interface.cc (right):

http://codereview.appspot.com/4814041/diff/24001/lily/axis-group-interface.cc#newcode82
lily/axis-group-interface.cc:82:
Axis_group_interface::relative_maybe_bound_group_extent (vector<Grob*>
const &elts,
vector<Grob *>

http://codereview.appspot.com/4814041/diff/24001/lily/axis-group-interface.cc#newcode109
lily/axis-group-interface.cc:109: vector<Grob*> new_elts;
vector<Grob *>

http://codereview.appspot.com/4814041/diff/24001/lily/axis-group-interface.cc#newcode118
lily/axis-group-interface.cc:118: if (new_elts.size () == 0)
!new_elts.size ()

http://codereview.appspot.com/4814041/diff/24001/lily/axis-group-interface.cc#newcode846
lily/axis-group-interface.cc:846: "bound-alignment-interfaces "
tab

http://codereview.appspot.com/4814041/diff/24001/lily/axis-group-interface.cc#newcode847
lily/axis-group-interface.cc:847: "default-staff-staff-spacing "
tab

http://codereview.appspot.com/4814041/diff/24001/lily/hairpin.cc
File lily/hairpin.cc (right):

http://codereview.appspot.com/4814041/diff/24001/lily/hairpin.cc#newcode144
lily/hairpin.cc:144: Interval e = (Axis_group_interface::has_interface
(b)
tab

http://codereview.appspot.com/4814041/diff/24001/lily/include/axis-group-interface.hh
File lily/include/axis-group-interface.hh (right):

http://codereview.appspot.com/4814041/diff/24001/lily/include/axis-group-interface.hh#newcode50
lily/include/axis-group-interface.hh:50: static Interval
relative_maybe_bound_group_extent (vector<Grob*> const &list,
vector<Grob *>

http://codereview.appspot.com/4814041/diff/24001/lily/include/axis-group-interface.hh#newcode51
lily/include/axis-group-interface.hh:51: Grob *common, Axis, bool);
indent

http://codereview.appspot.com/4814041/diff/24001/lily/line-spanner.cc
File lily/line-spanner.cc (right):

http://codereview.appspot.com/4814041/diff/24001/lily/line-spanner.cc#newcode112
lily/line-spanner.cc:112: Interval extent = (Paper_column::has_interface
(bound_grob)
if you change this to Axis_group_interface::has_interface () you should
be able to remove the special case in separation-item.cc for arpeggios
(and restore the old code which was replaced for issue 591 in
rhythmic-column-engraver.cc)

http://codereview.appspot.com/4814041/diff/24001/lily/line-spanner.cc#newcode118
lily/line-spanner.cc:118: details);
tabs

http://codereview.appspot.com/4814041/