Re: Does better polynomial calculations for avoid objects. (issue 4860042)

[mtsolo]

Thanks Joe!
New patchset uploaded.

Cheers,
MS


http://codereview.appspot.com/4860042/diff/1/flower/polynomial.cc
File flower/polynomial.cc (right):

http://codereview.appspot.com/4860042/diff/1/flower/polynomial.cc#newcode65
flower/polynomial.cc:65: Polynomial::minmax (Real l, Real r, bool dir)
const
On 2011/08/18 21:36:45, joeneeman wrote:
> Perhaps "bool max" instead of "bool dir"?

Done.

http://codereview.appspot.com/4860042/diff/1/lily/bezier.cc
File lily/bezier.cc (right):

http://codereview.appspot.com/4860042/diff/1/lily/bezier.cc#newcode87
lily/bezier.cc:87: Axis other = Axis ((a + 1) % NO_AXES);
On 2011/08/18 21:36:45, joeneeman wrote:
> Use the other_axis function.

Done.

http://codereview.appspot.com/4860042/diff/1/lily/bezier.cc#newcode217
lily/bezier.cc:217: Bezier::minmax (Axis ax, Real l, Real r, Direction
d) const
On 2011/08/18 21:36:45, joeneeman wrote:
> What is this function supposed to do?

This is like other_coordinate insofar as it is a fancy wrapper around a
polynomial function that.  It finds the max or min along the bezier
between l and r.

http://codereview.appspot.com/4860042/diff/1/lily/bezier.cc#newcode239
lily/bezier.cc:239: return p.minmax (sol[LEFT][0], sol[RIGHT][0], d !=
LEFT);
On 2011/08/18 21:36:45, joeneeman wrote:
> If there are multiple intersections with (say) r, then
Polynomial::solve doesn't
> seem to return them in any useful order. So sol[RIGHT][0] is really
just an
> arbitrary solution, isn't it?

True, but this seems no worse than line 81 where ts[0] is returned.  Not
that this is a good excuse...
I'll overload the function such that 0 is a default.

http://codereview.appspot.com/4860042/