lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Lilypond-book: get rid of lilyquote snippet option, use quot


From: Phil Holmes
Subject: Re: [PATCH] Lilypond-book: get rid of lilyquote snippet option, use quote instead
Date: Mon, 22 Aug 2011 15:34:16 +0100

----- Original Message ----- From: "Reinhold Kainhofer" <address@hidden>
To: "LilyPond Development" <address@hidden>
Sent: Monday, August 22, 2011 12:01 PM
Subject: [PATCH] Lilypond-book: get rid of lilyquote snippet option,use quote instead


Here's a patch that removes the lilyquote snippet option, since it doesn't
really give any benefit over using the quote option. The only difference
between the lilyquote and quote options so far was that with lilyquote the
texinfo and doctitle was outside the example block.

However, we didn't use quote together with those texinfo texts, so there is really no need to have both. This patch changes the 'quote' snippet option to have the texinfo texts outside the @example section. So, all LSR snippets in
our docs can now also simply use quote instead of lilyquote (I have a long
patch for the docs that replaces all lilyquote with quote and removed
lilyquote from the lilypond-book usage docs. I didn't include that patch here,
because it touches so many files in Documentation/ and is a simple
search&replace exercise that I will push once this patch is agreed upon).

Please review:
http://codereview.appspot.com/4921050

Cheers,
Reinhold


LGTM

--
Phil Holmes




reply via email to

[Prev in Thread] Current Thread [Next in Thread]