[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Makes sure that ledger lines do not overlap with accidentals. (issue
From: |
Mike Solomon |
Subject: |
Re: Makes sure that ledger lines do not overlap with accidentals. (issue 4898060) |
Date: |
Tue, 23 Aug 2011 08:59:50 +0200 |
Hey all,
My patch did change output (it prevented duplicate ledger lines), although I
did not spot the result that Janek sees.
The old patch is also flawed, in that it only changes the ledger line directly
next to the accidental. The entire bounding box of the accidental should,
however, be taken into account.
I maintain that the best solution is:
{
\override Staff.Accidental #'layer = #-100
\override Staff.LedgerLineSpanner #'layer = #-101
\override Staff.Accidental #'whiteout = ##t
<des ces'>
}
Which is a trivial change to engravers-init.ly. I'll post a patch later today
unless anyone sees a better alternative.
Cheers,
MS
On Aug 22, 2011, at 11:33 PM, Han-Wen Nienhuys wrote:
> 2011/8/22 Janek Warchoł <address@hidden>:
>> I wholeheartedly disagree, i think that this issue isn't negligible
>> (or did i misunderstood you, Han-Wen?).
>
> My impression is that the patch was not actually changing output.
>
> If it was intended to, I couldn't tell from a read of the patch.
>
> --
> Han-Wen Nienhuys - address@hidden - http://www.xs4all.nl/~hanwen
>
> _______________________________________________
> lilypond-devel mailing list
> address@hidden
> https://lists.gnu.org/mailman/listinfo/lilypond-devel
- Re: Makes sure that ledger lines do not overlap with accidentals. (issue 4898060), hanwenn, 2011/08/18
- Re: Makes sure that ledger lines do not overlap with accidentals. (issue 4898060), mtsolo, 2011/08/18
- Re: Makes sure that ledger lines do not overlap with accidentals. (issue 4898060), Han-Wen Nienhuys, 2011/08/18
- Re: Makes sure that ledger lines do not overlap with accidentals. (issue 4898060), Mike Solomon, 2011/08/18
- Re: Makes sure that ledger lines do not overlap with accidentals. (issue 4898060), Janek Warchoł, 2011/08/22
- Re: Makes sure that ledger lines do not overlap with accidentals. (issue 4898060), Han-Wen Nienhuys, 2011/08/22
- Re: Makes sure that ledger lines do not overlap with accidentals. (issue 4898060),
Mike Solomon <=
- Re: Makes sure that ledger lines do not overlap with accidentals. (issue 4898060), Han-Wen Nienhuys, 2011/08/23
- Re: Makes sure that ledger lines do not overlap with accidentals. (issue 4898060), Mike Solomon, 2011/08/23
- Re: Makes sure that ledger lines do not overlap with accidentals. (issue 4898060), Han-Wen Nienhuys, 2011/08/23
- Re: Makes sure that ledger lines do not overlap with accidentals. (issue 4898060), Jan Nieuwenhuizen, 2011/08/23
- Re: Makes sure that ledger lines do not overlap with accidentals. (issue 4898060), Janek Warchoł, 2011/08/27
- Re: Makes sure that ledger lines do not overlap with accidentals. (issue 4898060), Jan Nieuwenhuizen, 2011/08/27
- Re: Makes sure that ledger lines do not overlap with accidentals. (issue 4898060), Carl Sorensen, 2011/08/27
- Re: Makes sure that ledger lines do not overlap with accidentals. (issue 4898060), Keith OHara, 2011/08/23
- Re: Makes sure that ledger lines do not overlap with accidentals. (issue 4898060), Janek Warchoł, 2011/08/27