[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: include lines in breve X-extent (issue 1814) (issue 4931043)
From: |
bordage . bertrand |
Subject: |
Re: include lines in breve X-extent (issue 1814) (issue 4931043) |
Date: |
Thu, 25 Aug 2011 15:03:04 +0000 |
Sorry, I forgot to send the comments.
http://codereview.appspot.com/4931043/diff/1/mf/feta-noteheads.mf
File mf/feta-noteheads.mf (right):
http://codereview.appspot.com/4931043/diff/1/mf/feta-noteheads.mf#newcode168
mf/feta-noteheads.mf:168: gap# := (0.95 - 0.008 * design_size) *
stemthick#;
You should save gap, line 161.
http://codereview.appspot.com/4931043/diff/1/mf/feta-noteheads.mf#newcode169
mf/feta-noteheads.mf:169: define_pixels (gap);
This should be moved after set_char_box.
http://codereview.appspot.com/4931043/diff/1/mf/feta-noteheads.mf#newcode213
mf/feta-noteheads.mf:213: draw_gridline (z1 - (i * (gap + stemthick),
0),
Hmmm... Don't you think (i * (gap + stemthick), 0) has to be written one
time instead of four ?
http://codereview.appspot.com/4931043/