Re: Fixes missing images in big website page (issue 4964041)

[percival . music . ca]

http://codereview.appspot.com/4964041/diff/3001/make/website.make
File make/website.make (right):

http://codereview.appspot.com/4964041/diff/3001/make/website.make#newcode57
make/website.make:57: ### only update this when the language compiles
correctly!
On 2011/08/27 09:55:25, PhilEHolmes wrote:
> I wasn't ignoring the comment.  I read it as saying that we should
only add a
> language to the list when it compiles clean.  Perhaps this warning
should be
> added to langdef.py?

I don't mind having broken translations in the main documentation (IIRC
every language is broken in some respect), but I don't want the main
public website having a significantly broken translation.

I'd rather keep this list separate.  I suppose that technically it could
still be put into langdefs.py and define a list of "all translations"
and another list of "website-approved translations", but that would
involve a lot more playing with the build system and I don't think it's
worth it.  I guess I'm not opposed to it in principle, as long as the
build still works for all cases.

http://codereview.appspot.com/4964041/diff/3001/scripts/build/create-weblinks-itexi.py
File scripts/build/create-weblinks-itexi.py (right):

http://codereview.appspot.com/4964041/diff/3001/scripts/build/create-weblinks-itexi.py#newcode12
scripts/build/create-weblinks-itexi.py:12: import langdefs
On 2011/08/27 09:55:25, PhilEHolmes wrote:
> Yes.  In truth I'm not sure why, but this runs quite happily with make
website.
> It will not run if you try to run create-weblinks-itexi.py from the
command
> line, so there must be paths added during the make.

Please note that the full website build must work without running
../configure or make.  I really don't think that you can get away with
an import langdefs here -- at least, not without changing many more
parts of website.make.

http://codereview.appspot.com/4964041/