Re: Fix memleak: temporary skyline objects for systems were never deleted (issue 4923048)

[Dan Eble]

On 2011-08-27, at 04:20 , address@hidden wrote:

> passes make and reg tests
> 
> http://codereview.appspot.com/4923048/


You could clean up Skyline::distance by pulling lines 532-548 into their own 
function and letting Skyline::distance call it with different options:

if (horizon_padding != 0.0)
  {
    Skyline padded_this(. . .);
    Skyline padded_other(. . .);
    return unpadded_distance(padded_this, padded_other);
  }
else
  {
    return unpadded_distance(this, &other);
  }
-- 
Dan