Re: Creates pure closures (issue 4894052)

[Mike Solomon]

On Aug 31, 2011, at 10:37 PM, address@hidden wrote:

> On 2011/08/20 20:21:30, mikesol_ufl.edu wrote:
> 
>> I'll try to think of something better...if you have any suggestions in
> the
>> meantime, they're certainly welcome!
> 
> Something using a stencil override?
> 

The problem is that stencils are never considered pure/unpure - they are just 
used in grob::pure-height.
I've changed it to Flag instead of Stem to avoid it duplicating the Stem 
override of which you speak.

>> >
> http://codereview.appspot.com/4894052/diff/9001/lily/pure-closure.cc#newcode68
>> > lily/pure-closure.cc:68: assert (is_pure_closure (pc));
>> > optimized builds will segfault on invalid args, so you should use
>> > LY_ASSERT_TYPE () here
>> >
> 
>> Done.
> 
> Not in this patchset.
> 

Fixed.

> 
>> >
> http://codereview.appspot.com/4894052/diff/9001/lily/pure-closure.cc#newcode76
>> > lily/pure-closure.cc:76: assert (is_pure_closure (pc));
>> > LY_ASSERT_TYPE ()
>> >
> 
>> Done.
> 
> Not in this patchset.

Fixed.