Re: include lines in breve X-extent (issue 1814) (issue 4931043)

[janek . lilypond]

Ian,

On 2011/08/30 10:29:42, Ian Hulin (gmail) wrote:
> Janek,
> Bertrand posted some review comments here.

> I think it would be polite in the case of
> a newer contributor like Bertrand to
> post some responses one way or another
> (either "don't worry about it, because. .
> ." or "nice catch, I'll upload an updated patch set".)

You are absolutely right!  I had limited access to my e-mail and missed
this.  Sorry, Bertrand!

I have new patch set ready, but i have trouble logging as another user
in git-cl (this issue was created by my previous e-mail account).  Can
you give me some clue?


http://codereview.appspot.com/4931043/diff/1/mf/feta-noteheads.mf
File mf/feta-noteheads.mf (right):

http://codereview.appspot.com/4931043/diff/1/mf/feta-noteheads.mf#newcode168
mf/feta-noteheads.mf:168: gap# := (0.95 - 0.008 * design_size) *
stemthick#;
On 2011/08/25 15:03:04, Bertrand Bordage wrote:
> You should save gap, line 161.

Done.

http://codereview.appspot.com/4931043/diff/1/mf/feta-noteheads.mf#newcode169
mf/feta-noteheads.mf:169: define_pixels (gap);
On 2011/08/25 15:03:04, Bertrand Bordage wrote:
> This should be moved after set_char_box.

Done.

http://codereview.appspot.com/4931043/diff/1/mf/feta-noteheads.mf#newcode213
mf/feta-noteheads.mf:213: draw_gridline (z1 - (i * (gap + stemthick),
0),
On 2011/08/25 15:03:04, Bertrand Bordage wrote:
> Hmmm... Don't you think (i * (gap + stemthick), 0) has to be written
one time
> instead of four ?

I'm not sure what you mean.  Are you saying that i should assign (i *
(gap + stemthick), 0) to a variable in the for loop?  I.e. sth like

        for i := 0 step 1 until linecount - 1:
                foobar := (i * (gap + stemthick), 0);
                draw_gridline (z1 - foobar,
                               z2 - foobar,
                               stemthick);
                draw_gridline (z3 + foobar,
                               z4 + foobar,
                               stemthick);
        endfor;
?

http://codereview.appspot.com/4931043/