[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: change longas similarly to how breves were changed (issue 4962072)
From: |
janek . lilypond |
Subject: |
Re: change longas similarly to how breves were changed (issue 4962072) |
Date: |
Tue, 13 Sep 2011 15:24:57 +0000 |
New patch set uploaded.
http://codereview.appspot.com/4962072/diff/1/mf/feta-noteheads.mf
File mf/feta-noteheads.mf (right):
http://codereview.appspot.com/4962072/diff/1/mf/feta-noteheads.mf#newcode120
mf/feta-noteheads.mf:120:
On 2011/09/13 08:58:57, Ian Hulin (gmail) wrote:
foobar = quanted_line_length * staff_space;
% because you use 'quanted_line_length * staff_space' four times in
the code
below
Done.
http://codereview.appspot.com/4962072/diff/1/mf/feta-noteheads.mf#newcode123
mf/feta-noteheads.mf:123: top y2 = quanted_line_length * staff_space;
On 2011/09/13 08:58:57, Ian Hulin (gmail) wrote:
bot y1 = -foobar;
top y2 = foobar;
% see comment above
Done.
http://codereview.appspot.com/4962072/diff/1/mf/feta-noteheads.mf#newcode133
mf/feta-noteheads.mf:133: top y2 = quanted_line_length * staff_space;
On 2011/09/13 08:58:57, Ian Hulin (gmail) wrote:
top y2 = foobar;
% see comment above
Done.
http://codereview.appspot.com/4962072/diff/1/mf/feta-noteheads.mf#newcode140
mf/feta-noteheads.mf:140: bot y3 = -quanted_line_length * staff_space;
On 2011/09/13 08:58:57, Ian Hulin (gmail) wrote:
bot y3 = -foobar;
% see comment above
Done.
http://codereview.appspot.com/4962072/
- change longas similarly to how breves were changed (issue 4962072), janek . lilypond, 2011/09/12
- Re: change longas similarly to how breves were changed (issue 4962072), ianhulin44, 2011/09/13
- Re: change longas similarly to how breves were changed (issue 4962072), bordage . bertrand, 2011/09/13
- Re: change longas similarly to how breves were changed (issue 4962072),
janek . lilypond <=
- Re: change longas similarly to how breves were changed (issue 4962072), ianhulin44, 2011/09/13
- Re: change longas similarly to how breves were changed (issue 4962072), pkx166h, 2011/09/14
- Re: change longas similarly to how breves were changed (issue 4962072), janek . lilypond, 2011/09/17