Re: Implement optional music function arguments (issue 5023044)

[ianhulin44]

Looks pretty cool, apart from some involved Scheme which I couldn't
really unravel totally (see below).

Will this patch allow us to get rid of the abomination of
\afterGraceFraction by recasting \afterGrace to have an optional
parameter
\afterGrace {note} {gracenotes} [spacing-fraction]
e.g.
c1 \afterGrace d1 { c16[ d] } c1 ;; use default spacing
c1 \afterGrace d1 { c16[ d] } 15/16 c1
;or
c1 \afterGrace d1 { c16[ d] } 1/2 c1
;instead of
#(define afterGraceFraction (cons 15 16))
c1 \afterGrace d1 { c16[ d] } c1
;or
#(define afterGraceFraction (cons 1 2))
c1 \afterGrace d1 { c16[ d] } c1

Keep up the good work, and thanks.
Ian


http://codereview.appspot.com/5023044/diff/9001/scm/document-identifiers.scm
File scm/document-identifiers.scm (right):

http://codereview.appspot.com/5023044/diff/9001/scm/document-identifiers.scm#newcode33
scm/document-identifiers.scm:33: (format $f "(~a)" (type-name pred)))))
What does $f do in the format destination here, where's it declared? The
Guile documentation mentions #f returning the output as a string,
otherwise it's a port. So what port does $f represent?
Does this tie up with the (define-syntax-function) changes in
music-functions.scm?  Is $f definitely not a typo?
Comment this section, please, David.

http://codereview.appspot.com/5023044/