Re: T1780 remove scheme format calls with no destination parameter - deprecated in Guile V2 (issue 4974078)

[bordage . bertrand]

Hi Ian,

I have some comments. The rest of the patch LGTM.

Regards,
Bertrand


http://codereview.appspot.com/4974078/diff/3001/scm/document-identifiers.scm
File scm/document-identifiers.scm (right):

http://codereview.appspot.com/4974078/diff/3001/scm/document-identifiers.scm#newcode31
scm/document-identifiers.scm:31:
Why a new line?

http://codereview.appspot.com/4974078/diff/3001/scm/lily.scm
File scm/lily.scm (right):

http://codereview.appspot.com/4974078/diff/3001/scm/lily.scm#newcode353
scm/lily.scm:353: (ly:format
Err...
Why is this required?

Be careful with the indentation: there shouldn't be tabulators.

http://codereview.appspot.com/4974078/diff/3001/scripts/musicxml2ly.py
File scripts/musicxml2ly.py (right):

http://codereview.appspot.com/4974078/diff/3001/scripts/musicxml2ly.py#newcode71
scripts/musicxml2ly.py:71: (ly:format #f "~a:~a" den num)))
#f?

http://codereview.appspot.com/4974078/