lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: musicxml2ly: title and subtitle (issue 1913), miscellaneous (issue 5


From: janek . lilypond
Subject: Re: musicxml2ly: title and subtitle (issue 1913), miscellaneous (issue 5096050)
Date: Thu, 22 Sep 2011 12:50:43 +0000

Some concerns and a handful of questions (as usual in my case).


http://codereview.appspot.com/5096050/diff/1/python/musicexp.py
File python/musicexp.py (right):

http://codereview.appspot.com/5096050/diff/1/python/musicexp.py#newcode63
python/musicexp.py:63: self.print_verbatim ('\\version "2.15.13"')
Isn't this a mistake?
If not, can it not be hardcoded?

http://codereview.appspot.com/5096050/diff/1/python/musicexp.py#newcode283
python/musicexp.py:283: return False
Can you add a comment saying what does this do?
I'd appreciate it, because i don't know :)

http://codereview.appspot.com/5096050/diff/1/python/musicxml.py
File python/musicxml.py (right):

http://codereview.appspot.com/5096050/diff/1/python/musicxml.py#newcode176
python/musicxml.py:176: for r in source:
What does this do?
Can you add a comment explaining this?

http://codereview.appspot.com/5096050/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]