[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Creates convert-ly rules for flag syntax changes (issue 5050046)
|
From: |
k-ohara5a5a |
|
Subject: |
Re: Creates convert-ly rules for flag syntax changes (issue 5050046) |
|
Date: |
Tue, 27 Sep 2011 05:08:02 +0000 |
Looks good enough to me.
http://codereview.appspot.com/5050046/diff/1/python/convertrules.py
File python/convertrules.py (right):
http://codereview.appspot.com/5050046/diff/1/python/convertrules.py#newcode3241
python/convertrules.py:3241: str = re.sub
(r"Stem\s+#'transparent\s*=\s*##t", r"Stem #'transparent = ##t
\\override Flag #'transparent = ##t", str)
This last one gets fooled by the common case
\once\override Stem #'transparent
so maybe three separate substitutions rules, for \override
\once\s*\override \revert, or maybe a not_smart for the transparent
property.
http://codereview.appspot.com/5050046/