Re: Build dependencies for .texi files (issue 1852). (issue 5169041)

[reinhold . kainhofer]

I don't really like the naive approach of using the exact include file
as the make dependency, because that blatantly ignores all include path
settings for texinfo...


http://codereview.appspot.com/5169041/diff/1/Documentation/topdocs/AUTHORS.texi
File Documentation/topdocs/AUTHORS.texi (right):

http://codereview.appspot.com/5169041/diff/1/Documentation/topdocs/AUTHORS.texi#newcode13
Documentation/topdocs/AUTHORS.texi:13: @include ../macros.itexi
On 2011/09/30 11:41:50, Graham Percival wrote:
> this should be taken care of with the texinfo -I includedir stuff.
Which target
> does it fail with?  I'll fix that .make file.

The problem is not texinfo, but the way the .dep file for the
dependencies is created. It simply greps through the .texi file anc
extracts all @include .... entries as make dependencies. There are not
include pathes involved.

See the changes to texinfo-rules.make in this patch.

http://codereview.appspot.com/5169041/diff/1/stepmake/stepmake/texinfo-rules.make
File stepmake/stepmake/texinfo-rules.make (right):

http://codereview.appspot.com/5169041/diff/1/stepmake/stepmake/texinfo-rules.make#newcode28
stepmake/stepmake/texinfo-rules.make:28: sed -ne
"/address@hidden:space:]]/s/@include/.\/$(subst /,\/,$@):/p" $< >> $(subst
.texi,.dep,$@)
Shouldn't we do this in a separate rule to create the .dep file?

http://codereview.appspot.com/5169041/diff/1/stepmake/stepmake/texinfo-rules.make#newcode28
stepmake/stepmake/texinfo-rules.make:28: sed -ne
"/address@hidden:space:]]/s/@include/.\/$(subst /,\/,$@):/p" $< >> $(subst
.texi,.dep,$@)
This also does not work with nested includes.

http://codereview.appspot.com/5169041/