[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Adds Scheme function for spring constructor. (issue 5306050)
From: |
n . puttock |
Subject: |
Re: Adds Scheme function for spring constructor. (issue 5306050) |
Date: |
Fri, 21 Oct 2011 11:18:06 +0000 |
http://codereview.appspot.com/5306050/diff/1/lily/spring-smob.cc
File lily/spring-smob.cc (right):
http://codereview.appspot.com/5306050/diff/1/lily/spring-smob.cc#newcode48
lily/spring-smob.cc:48: "spring, and @code{min-dist} is the minimum
distance.")
@var{min-dist}
http://codereview.appspot.com/5306050/diff/2001/lily/spring-smob.cc
File lily/spring-smob.cc (left):
http://codereview.appspot.com/5306050/diff/2001/lily/spring-smob.cc#oldcode42
lily/spring-smob.cc:42: return a == b ? SCM_BOOL_T : SCM_BOOL_F;
Not sure why this doesn't use the DEFAULT_EQUAL_P macro.
Also should have IMPLEMENT_TYPE_P for ly:spring?
(+ entry in lily.scm)
http://codereview.appspot.com/5306050/diff/2001/lily/spring-smob.cc
File lily/spring-smob.cc (right):
http://codereview.appspot.com/5306050/diff/2001/lily/spring-smob.cc#newcode47
lily/spring-smob.cc:47: "Make a spring. @code{ideal} is the ideal
distance of the "
@var{ideal}
move space to start of next line
http://codereview.appspot.com/5306050/diff/2001/lily/spring-smob.cc#newcode48
lily/spring-smob.cc:48: "spring, and @code{min-dist} is the minimum
distance.")
@var{min-dist}
http://codereview.appspot.com/5306050/diff/2001/lily/spring-smob.cc#newcode60
lily/spring-smob.cc:60: "Set the inverse compress @code{strength} of
@code{spring}.")
@var{strength} @var{spring}
http://codereview.appspot.com/5306050/diff/2001/lily/spring-smob.cc#newcode72
lily/spring-smob.cc:72: "Set the inverse stretch @code{strength} of
@code{spring}.")
@var{strength} @var{spring}
http://codereview.appspot.com/5306050/
- Adds Scheme function for spring constructor. (issue 5306050), bordage . bertrand, 2011/10/21
- Re: Adds Scheme function for spring constructor. (issue 5306050),
n . puttock <=
- Re: Adds Scheme function for spring constructor. (issue 5306050), dak, 2011/10/21
- Re: Adds Scheme function for spring constructor. (issue 5306050), dak, 2011/10/21
- Re: Adds Scheme function for spring constructor. (issue 5306050), bordage . bertrand, 2011/10/21
- Re: Adds Scheme function for spring constructor. (issue 5306050), dak, 2011/10/21
- Re: Adds Scheme function for spring constructor. (issue 5306050), mtsolo, 2011/10/23