13:35:08 up 20:27, 2 users, load average: 0.07, 0.07, 0.07 (issue 5464045)

[Carl . D . Sorensen]

Hi Ian,

I feel pretty much unqualified to comment on this, since the details are
way over my head.  Since it works (and you've tested it on both 1.8 and
2), I assume that most things about it are OK.

I have a couple of questions:

1) How do we decide when we need to include (use-modules  (scm
markup-facility-defs)) in our input files?  Is it to be included any
time we define our own markup commands?

2) It seems you've replaced format with fancy-format in multiple places,
even though in your patch set you only describe doing it once.  I
understand the need of using fancy-format when doing the roman numeral
formatting, but I'm not sure why you've changed it in the other places.

Thanks,

Carl



http://codereview.appspot.com/5464045/diff/2001/scm/define-markup-commands.scm
File scm/define-markup-commands.scm (right):

http://codereview.appspot.com/5464045/diff/2001/scm/define-markup-commands.scm#newcode1989
scm/define-markup-commands.scm:1989: prev-result)))
The previous spacing was correct.  prev-result should align with
(char-list

http://codereview.appspot.com/5464045/diff/2001/scm/define-markup-commands.scm#newcode2194
scm/define-markup-commands.scm:2194: ;(start-repl)
Is this a leftover that should be removed?

http://codereview.appspot.com/5464045/