[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Broadcast articulations not in EventChord (issue 5528111)
From: |
mtsolo |
Subject: |
Broadcast articulations not in EventChord (issue 5528111) |
Date: |
Tue, 17 Jan 2012 17:42:38 +0000 |
I would advise not handling it this way - the function to_event is
supposed to take music and return an event. In this patch, it is taking
music, returning an event, and maybe broadcasting music and/or sending
it to a context.
I'd recommend creating a new iterator, rhythmic-music-iterator, that
inherits from Simple_music_iterator. Have this be the constructor for
the NoteEvent and RestEvent (iterator-ctor). Then, in this iterator,
duriing process_music, have something that looks at an "articulations"
callback of the iterator. This callback would handle the articulations
list, much like the "elements-callback" handles the elements list (see
the sequential-iterator). This is more in keeping with the way the code
is written and would make it easier to follow/debug.
Cheers,
MS
http://codereview.appspot.com/5528111/
- Broadcast articulations not in EventChord (issue 5528111),
mtsolo <=