lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: some comments and complaints on the code (issue 5651069)


From: janek . lilypond
Subject: Re: some comments and complaints on the code (issue 5651069)
Date: Sat, 11 Feb 2012 13:07:37 +0000

new patch set uploaded, please review.


http://codereview.appspot.com/5651069/diff/1/lily/note-collision.cc
File lily/note-collision.cc (right):

http://codereview.appspot.com/5651069/diff/1/lily/note-collision.cc#newcode588
lily/note-collision.cc:588: {
On 2012/02/11 12:32:57, Milimetr88 wrote:
On 2012/02/10 23:49:24, Carl wrote:
> I don't know that we have a specification for this, or if it can be
handled by
> fixcc.py, but for consistency with the way we indent braces with
loops and if,
> the braces should be indented two spaces, IMO.

Done. Janek will push it soon. Maybe fixcc will not change it back...

I've checked that fixcc will change this if it's ran on the file.  No
need to do this, though.
I'll add an issue about fixing fixcc.

http://codereview.appspot.com/5651069/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]