Re: Corrected style of comments (issue 5862052)

[Łukasz Czerwiński]

Thanku you, Janek and James.

Wouldn't it be nicer for git cl to ask for an issue number in case it is unknown? Default value (e.g. 0) could mean a new issue, but the programmer would have an opportunity to type the right issue number.

Łukasz

On 31 March 2012 22:46, James <address@hidden> wrote:

Hello,

2012/3/31 Janek Warchoł <address@hidden>:

> On Sat, Mar 31, 2012 at 6:13 PM,  <address@hidden> wrote:
>> I'm sorry for that, but the next bunch of corrections are in a separate
>> issue: http://codereview.appspot.com/5975054
>>
>> It seems that following the procedure from
>> http://lilypond.org/doc/v2.15/Documentation/contributor/commits-and-patches#uploading-a-patch-for-review
>> does not make git-cl ask for the issue number. Instead it creates a new
>> one. How to change that? Always call 'git cl issue' before 'git cl
>> upload'?
>
> The information about Rietveld issue is stored in your git config, in
> the properties of the branch you used when you uploaded first.  If you
> upload new patch revision from a new branch, the script doesn't know
> what rietveld number is because it doesn't see it in branch
> properties.  It's a good practice to use one branch for your fix.

I find that using 'git-cl issue 0' helps to 'reset' any doubts abuot
what git-cl thinks it has currently. I use a VM with Lilydev and have
a number of patches on the go, so forget which is which, so just reset
git-cl and then either let git-cl create my new issue number or I find
my rietveld issue and then run git-cl issue XXXX where XXXX is the
rietveld number. Then I know I am good to go.

James