lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Allow tweaks in Lyrics. (issue 6221046)


From: dak
Subject: Re: Allow tweaks in Lyrics. (issue 6221046)
Date: Mon, 21 May 2012 07:49:48 +0000

Reviewers: Keith,

Message:
On 2012/05/21 06:25:13, Keith wrote:
I'm having difficulty demonstrating that this works.

\layout { \context { \Lyrics \consists "Tweak_engraver" }}
\relative c' {c d e f }
\addlyrics { ut \tweak #'color #'red re mi fa }
?

This "\consists" has the same effect as this patch, making tweaks work
in lyrics, so you either need this patch, or this context def
redefinition but not both.  The symbol 'red is not a valid color, but
the value of the variable red, namely '(1.0 0.0 0.0), is.  If you write
#red or #'(1.0 0.0 0.0) instead of #'red you will be able to see an
effect.

Description:
Allow tweaks in Lyrics.

Since lyrics are no longer wrapped in EventChord, there is no point
in keeping tweaks from working inside of Lyrics contexts.

Please review this at http://codereview.appspot.com/6221046/

Affected files:
  M ly/engraver-init.ly


Index: ly/engraver-init.ly
diff --git a/ly/engraver-init.ly b/ly/engraver-init.ly
index 5710d4f6b214ff67eeda820c083d603c52060ad0..c4ecf261aa358dd79bcbd2ec7be99eae42fc3bd9 100644
--- a/ly/engraver-init.ly
+++ b/ly/engraver-init.ly
@@ -435,6 +435,7 @@ printing of a single line of lyrics."
   \consists "Lyric_engraver"
   \consists "Extender_engraver"
   \consists "Hyphen_engraver"
+  \consists "Tweak_engraver"
   \consists "Stanza_number_engraver"
   \consists "Instrument_name_engraver"
   \consists "Font_size_engraver"





reply via email to

[Prev in Thread] Current Thread [Next in Thread]