[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Sets TabVoice Stem height to ##f (issue 6303065)
From: |
k-ohara5a5a |
Subject: |
Re: Sets TabVoice Stem height to ##f (issue 6303065) |
Date: |
Mon, 11 Jun 2012 16:33:27 +0000 |
LGTM if you re-read the comment before you push.
http://codereview.appspot.com/6303065/diff/9001/lily/stem.cc
File lily/stem.cc (right):
http://codereview.appspot.com/6303065/diff/9001/lily/stem.cc#newcode707
lily/stem.cc:707: return an empty interval when there is no beam.
The comment doesn't exactly match the code (we the full stem interval
for the imaginary stems on beamed rests, not just a point) so take
another read before you push. Maybe let the code show what you do, and
just say why you do it. "If there is a beam but no stem, slope
calculations depend on this routine to return where the stem end /would/
be."
http://codereview.appspot.com/6303065/diff/9001/lily/stem.cc#newcode710
lily/stem.cc:710: if (calc_beam && !beam && !unsmob_stencil
(me->get_property ("stencil")))
If you have time to test the output, consider removing the test for
calc_beam, and combining with similar line 692.
http://codereview.appspot.com/6303065/
- Sets TabVoice Stem height to ##f (issue 6303065), mtsolo, 2012/06/10
- Re: Sets TabVoice Stem height to ##f (issue 6303065), dak, 2012/06/10
- Re: Sets TabVoice Stem height to ##f (issue 6303065), dak, 2012/06/11
- Re: Sets TabVoice Stem height to ##f (issue 6303065), mtsolo, 2012/06/11
- Re: Sets TabVoice Stem height to ##f (issue 6303065), dak, 2012/06/11
- Re: Sets TabVoice Stem height to ##f (issue 6303065), mtsolo, 2012/06/11
- Re: Sets TabVoice Stem height to ##f (issue 6303065),
k-ohara5a5a <=
- Re: Sets TabVoice Stem height to ##f (issue 6303065), dak, 2012/06/12
- Re: Sets TabVoice Stem height to ##f (issue 6303065), mtsolo, 2012/06/12
- Re: Sets TabVoice Stem height to ##f (issue 6303065), dak, 2012/06/12
- Re: Sets TabVoice Stem height to ##f (issue 6303065), mtsolo, 2012/06/12
- Re: Sets TabVoice Stem height to ##f (issue 6303065), dak, 2012/06/12
- Re: Sets TabVoice Stem height to ##f (issue 6303065), mtsolo, 2012/06/12
- Re: Sets TabVoice Stem height to ##f (issue 6303065), dak, 2012/06/12
- Re: Sets TabVoice Stem height to ##f (issue 6303065), mtsolo, 2012/06/12
- Re: Sets TabVoice Stem height to ##f (issue 6303065), dak, 2012/06/12
- Re: Sets TabVoice Stem height to ##f (issue 6303065), dak, 2012/06/15