[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: cleanup: infinity, get property (issue 6310043)
From: |
janek . lilypond |
Subject: |
Re: cleanup: infinity, get property (issue 6310043) |
Date: |
Thu, 14 Jun 2012 22:33:13 +0000 |
Hi,
i've moved things around. I've used your suggestion to check if it
works at all - it works, but the results are wrong ;) That's not a
problem, though; I'll fix them tomorrow. Meanwhile please take a look
at my previous comments in Lyric_engraver (before the function was
moved):
http://codereview.appspot.com/6310043/diff/1/lily/lyric-engraver.cc
http://codereview.appspot.com/6310043/diff/1/lily/lyric-engraver.cc
File lily/lyric-engraver.cc (right):
http://codereview.appspot.com/6310043/diff/1/lily/lyric-engraver.cc#newcode42
lily/lyric-engraver.cc:42: TRANSLATOR_DECLARATIONS (Lyric_engraver);
On 2012/06/14 08:19:01, MikeSol wrote:
You'll need to create a lyric-text.cc and put this in there.
Then, in ADD_INTERFACE (Lyric_text, "foo" "bar" "etc.") you'll need to
add the
property min-X-offset.
Done.
http://codereview.appspot.com/6310043/diff/1/scm/define-grobs.scm
File scm/define-grobs.scm (right):
http://codereview.appspot.com/6310043/diff/1/scm/define-grobs.scm#newcode1283
scm/define-grobs.scm:1283: (X-offset .
,ly:lyric-engraver::calc-x-offset)
On 2012/06/14 18:40:02, janek wrote:
On 2012/06/14 08:19:01, MikeSol wrote:
> You want this to be ly:lyric-text::calc-x-offset
ok
Done.
http://codereview.appspot.com/6310043/
- Re: cleanup: infinity, get property (issue 6310043),
janek . lilypond <=
- Re: cleanup: infinity, get property (issue 6310043), janek . lilypond, 2012/06/15
- Re: cleanup: infinity, get property (issue 6310043), dak, 2012/06/15
- Re: cleanup: infinity, get property (issue 6310043), Janek Warchoł, 2012/06/15
- Re: cleanup: infinity, get property (issue 6310043), David Kastrup, 2012/06/15
- Re: cleanup: infinity, get property (issue 6310043), Janek Warchoł, 2012/06/15
- Re: cleanup: infinity, get property (issue 6310043), David Kastrup, 2012/06/15
- Re: cleanup: infinity, get property (issue 6310043), Janek Warchoł, 2012/06/15
- Re: cleanup: infinity, get property (issue 6310043), David Kastrup, 2012/06/15
Re: cleanup: infinity, get property (issue 6310043), janek . lilypond, 2012/06/15
Re: cleanup: infinity, get property (issue 6310043), dak, 2012/06/15