Re: add general_alignment (issue 2613) (issue 6308093)

[k-ohara5a5a]

This fails an assertion in scm_or_str2symbol, so I had to recompile with
NDEBUG

On 2012/06/21 07:36:31, janek wrote:

> Nevertheless, it's possible to override X-offset property on the
>   ly code to use this:
> \override LyricText #'X-offset =
>   #(ly:make-simple-closure (ly:make-simple-closure
>     (list ly:self-alignment-interface::general-x-alignment)))

 .. = #ly:self-alignment-interface::general-x-alignment
I don t know Scheme, but I see no need to wrap in closures.

> This is no longer a draft; let me know if it's ready to
> be added to the source.

The new property X-alignment will be awkward to use, because it is a
complex structure of unnamed conceptually-distinct objects.

As you have built it, a list of pairs, I can do things like
 \override LyricText #'X-alignment #'X-extent = #RIGHT
but I don't think that was intended.

The objects in X-alignment could be individually-named properties:
 self-alignment-X-extent-symbol
 self-alignment-X (the existing property)
 parent-alignment-X
 parent-self-alignment-X-extent-symbol
 extra-X-offset

Will all of these be independently useful ?
I would like to see how this solves some engraving challenges, without
hand-calculation of the key numbers, before you push the C code.  There
will be a difficult convert-ly rule to write, if you have
general_alignment() in the 2.16 source, but then need to change the
interface.

http://codereview.appspot.com/6308093/