Re: CG: All engravers should have double-quotes around them (issue 6461098)

[dak]

Reviewers: Graham Percival,

Message:
On 2012/08/21 11:57:45, Graham Percival wrote:
> LGTM, but two questions:
> 1) why should engravers have double-quotes?

Because the CG states so.

> Was it only working by accident
> before, or are you hoping to simplify the parser by no longer
accepting the
> non-quoted versions?

Neither.  There are no plans to stop supporting underline-containing
unquoting strings, and the recent change unifying string syntax across
lexer modes reinforces this.

> 2) the patch title says "CG:", but this doesn't touch the CG.

But the CG touches the patch.  Concretely, it states:

<URL:http://lilypond.org/doc/v2.15/Documentation/contributor/lilypond-formatting>

All engravers should have double-quotes around them:

    \consists "Spans_arpeggio_engraver"

LilyPond does not strictly require this, but it is a useful convention
to follow.

Description:
CG: All engravers should have double-quotes around them

Please review this at http://codereview.appspot.com/6461098/

Affected files:
  M Documentation/changes.tely
  M Documentation/cs/learning/fundamental.itely
  M Documentation/cs/usage/lilypond-book.itely
  M Documentation/de/essay/engraving.itely
  M Documentation/de/learning/fundamental.itely
  M Documentation/de/notation/ancient.itely
  M Documentation/de/notation/changing-defaults.itely
  M Documentation/de/notation/percussion.itely
  M Documentation/de/notation/rhythms.itely
  M Documentation/de/notation/spacing.itely
  M Documentation/de/notation/vocal.itely
  M Documentation/de/usage/lilypond-book.itely
  M Documentation/es/changes.tely
  M Documentation/es/essay/engraving.itely
  M Documentation/es/learning/fundamental.itely
  M Documentation/es/notation/ancient.itely
  M Documentation/es/notation/changing-defaults.itely
  M Documentation/es/notation/percussion.itely
  M Documentation/es/notation/rhythms.itely
  M Documentation/es/notation/spacing.itely
  M Documentation/es/notation/vocal.itely
  M Documentation/es/usage/lilypond-book.itely
  M Documentation/essay/engraving.itely
  M Documentation/fr/essay/engraving.itely
  M Documentation/fr/learning/fundamental.itely
  M Documentation/fr/notation/ancient.itely
  M Documentation/fr/notation/changing-defaults.itely
  M Documentation/fr/notation/percussion.itely
  M Documentation/fr/notation/rhythms.itely
  M Documentation/fr/notation/spacing.itely
  M Documentation/fr/notation/vocal.itely
  M Documentation/fr/usage/lilypond-book.itely
  M Documentation/hu/learning/fundamental.itely
  M Documentation/hu/usage/lilypond-book.itely
  M Documentation/included/chord-names-jazz.ly
  M Documentation/included/chord-names-languages.ly
  M Documentation/it/learning/fundamental.itely
  M Documentation/it/usage/lilypond-book.itely
  M Documentation/ja/learning/fundamental.itely
  M Documentation/ja/notation/changing-defaults.itely
  M Documentation/ja/notation/percussion.itely
  M Documentation/ja/notation/rhythms.itely
  M Documentation/ja/notation/spacing.itely
  M Documentation/ja/notation/vocal.itely
  M Documentation/ja/usage/lilypond-book.itely
  M Documentation/learning/fundamental.itely
  M Documentation/ly-examples/ancient-headword.ly
  M Documentation/ly-examples/aucun-snippet.ly
  M Documentation/ly-examples/cary.ly
  M Documentation/nl/learning/fundamental.itely
  M Documentation/notation/ancient.itely
  M Documentation/notation/changing-defaults.itely
  M Documentation/notation/percussion.itely
  M Documentation/notation/rhythms.itely
  M Documentation/notation/spacing.itely
  M Documentation/notation/vocal.itely
  M  
Documentation/snippets/how-to-print-two-rehearsal-marks-above-and-below-the-same-barline-method-2.ly
  M Documentation/usage/lilypond-book.itely
  M input/regression/ambitus-slur.ly
  M input/regression/ambitus-with-ligature.ly
  M input/regression/beam-break-no-bar.ly
  M input/regression/chord-names-languages.ly
  M input/regression/custos.ly
  M input/regression/dot-column-engraver.ly
  M input/regression/horizontal-bracket-break.ly
  M input/regression/les-nereides.ly
  M input/regression/markup-scheme.ly
  M input/regression/markup-score.ly
  M input/regression/multi-measure-rest-instr-name.ly
  M input/regression/no-staff.ly
  M input/regression/spacing-clef-first-note.ly
  M input/regression/spacing-measure-length.ly
  M input/regression/staff-online-symbol-absence.ly
  M input/regression/tuplet-nest-broken.ly
  M input/regression/tuplet-no-stems.ly
  M ly/gregorian.ly