|
From: | john . mandereau |
Subject: | Re: Check for Fontforge with enable-double (1637) (issue 6484062) |
Date: | Sun, 26 Aug 2012 22:56:44 +0000 |
LGTM except one nitpick (see comment). http://codereview.appspot.com/6484062/diff/1/configure.in File configure.in (right): http://codereview.appspot.com/6484062/diff/1/configure.in#newcode174 configure.in:174: if $FONTFORGE --version 2>&1|egrep -q -e '-L?D\.?$'; then It seems that egrep vs. grep and egrep/grep -e flag are redundant, why not just have "grep -q -e" instead? http://codereview.appspot.com/6484062/
[Prev in Thread] | Current Thread | [Next in Thread] |