lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Patchy report


From: John Mandereau
Subject: Re: Patchy report
Date: Fri, 31 Aug 2012 15:50:34 +0200

Il giorno ven, 31/08/2012 alle 11.10 +0200, David Kastrup ha scritto:
> Some of the recent reports from Grenouille actually might suggest that
> it might be testing against an unrelated test-baseline.

Patchy currently doesn't check, and AFAIK has never checked, whether
master branch has changed between patches tests, so with the build speed
of Grenouille this issue may well have make this issue apparent in some
case.


>   Perhaps you are
> taking wrong shortcuts,

I have taken care in trying to deal with this, but there might be a bug.
Patchy is supposed to verify whether the test-baseline is up to date by
computing the SHA1 sum of the git committish of current master
(test-patches.py pulls just after having downloaded patches) plus the
contents of all files in out-test-baseline directories.  Perhaps  the
file names should be added in this checksum?


>  or are mixing up in-place and out-of-place
> builds

All builds in Patchy are done from a bare git repository, nobody builds
LilyPond manually in the chroot where Patchy runs, and now Patchy does
completely out-of-source builds.


>  or storing your test-baseline in a different place you read it
> from again?

out-test-baselines are never moved away and back by Patchy, so if you
don't simulteneously change the build directory in the configuration
file and move that build directory manually accordingly, that doesn't
happen.

Best,
John




reply via email to

[Prev in Thread] Current Thread [Next in Thread]