Re: [Lilypond-auto] Issue 2790 in lilypond: Patch: bar-line interface part 2/2

[Marc Hohl]

Am 31.08.2012 11:58, schrieb John Mandereau:
> Il giorno gio, 30/08/2012 alle 09.29 +0200, Marc Hohl ha scritto:
> > Am 30.08.2012 06:46, schrieb address@hidden:
> > > Comment #6 on issue 2790 by address@hidden: Patch: bar-line
> > > interface part 2/2
> > > http://code.google.com/p/lilypond/issues/detail?id=2790#c6
> > >
> > > Build results are available at
> > >
> > > http://grenouille.lilynet.net/patches-tests/2790/test-results
> > >
> > > 02:56:55 (UTC) Begin LilyPond compile, previous commit at
> > > ecf25f33aa4c02efda0694280e956c147f5006ae
> > > 02:57:02 Another instance (PID 16669) is already running.
> > > 03:27:19 Merged master, now at: ecf25f33aa4c02efda0694280e956c147f5006ae
> > > 03:27:21     Success:        sudo -u lilybuild ./autogen.sh --noconfigure
> > > 03:27:47     Success:        sudo -u lilybuild
> > > /home/lilybuild/master/configure --disable-optimising
> > > 03:27:57     Success:        sudo -u lilybuild nice make clean
> > > 03:43:41     Success:        sudo -u lilybuild nice make -j2
> > > CPU_COUNT=2 ANTI_ALIAS_FACTOR=1
> > > 04:05:21     Success:        sudo -u lilybuild nice make test-baseline
> > > -j2 CPU_COUNT=2 ANTI_ALIAS_FACTOR=1
> > >
> > > 04:05:30 Issue 2790: Patch: bar-line interface part 2/2
> > > 04:05:30 Issue 2790: Testing patch issue6498052_8001_diff
> > > 04:05:31     Success:        sudo -u lilybuild git apply --index
> > > /home/jmandereau/lily-test-patches/issue6498052_8001.diff
> > > 04:05:33     Success:        sudo -u lilybuild ./autogen.sh --noconfigure
> > > 04:05:59     Success:        sudo -u lilybuild
> > > /home/lilybuild/master/configure --disable-optimising
> > > 04:06:05     Success:        sudo -u lilybuild nice make clean
> > > 04:21:50     Success:        sudo -u lilybuild nice make -j2
> > > CPU_COUNT=2 ANTI_ALIAS_FACTOR=1
> > > 04:46:06     Success:        sudo -u lilybuild nice make check -j2
> > > CPU_COUNT=2 ANTI_ALIAS_FACTOR=1
> > I don't understand why grenouille finds a lot of differences for volta
> > brackets, whereas
> > my test results show only some minor changes in bar-lines.ly and
> > bar-line-segno.ly (apart from
> > output-distance.ly, of course).
Hi John,

> I retested your patch (not the one you submitted yesterday afternoon,
> but the one before), and found a lot of differences as well, which by
> the way are very similar to the test results of last patch by James and
> these by Grenouille.  If really you saw (or see again) only minor
> changes in only two tests whereas test results from James or Grenouille
> show a lot, could you double-check that you baselined with the correct
> revision of the sources?
I think I did it right; normally the workflow is

git checkout master; git pull
make test-clean; make; make test-baseline; make check

git checkout barlineII; git rebase master
make ; make test-redo; make check

bit probably I forgot something; it makes perfect sense that
the volta brackets show up in the regtests – with the current
code, they have to be wrong :-(

By the way, how about the

Parsed object should be dead: ...

messages? Any hints were they come from? I am not 100% sure,
but I think, they are not caused by my patch (hopeful guess ;-)

Regards,

Marc


> Best,
> John