lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Dynamics do not unnecessarily horizontal shift for stems. (issue 6493073


From: dak
Subject: Dynamics do not unnecessarily horizontal shift for stems. (issue 6493073)
Date: Sun, 02 Sep 2012 16:06:30 +0000


http://codereview.appspot.com/6493073/diff/1/lily/self-alignment-interface.cc
File lily/self-alignment-interface.cc (right):

http://codereview.appspot.com/6493073/diff/1/lily/self-alignment-interface.cc#newcode213
lily/self-alignment-interface.cc:213: vector_sort (vais, less<int> ());
Seriously?  If dir is UP, you are interested in the minimum, and if it
is DOWN, you are interested in the maximum.  And you create a vector and
sort it for that?

Totally inefficient as well as incomprehensible.

http://codereview.appspot.com/6493073/diff/1/lily/self-alignment-interface.cc#newcode280
lily/self-alignment-interface.cc:280: "potential-X-colliding-grobs "
Does normal-stems need to be here?

http://codereview.appspot.com/6493073/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]