Re: lilypond-book: treat iffalse sections in latex as block comments (issue 6584073)

[lemzwerg]

http://codereview.appspot.com/6584073/diff/1/python/book_latex.py
File python/book_latex.py (right):

http://codereview.appspot.com/6584073/diff/1/python/book_latex.py#newcode88
python/book_latex.py:88: \\iffalse.*\\fi))''',
On 2012/10/06 02:12:41, Julien Rioux wrote:
> .* should be replaced by the non-greedy .*?

Yes :-)

http://codereview.appspot.com/6584073/diff/1/python/book_latex.py#newcode88
python/book_latex.py:88: \\iffalse.*\\fi))''',
As David has commented on the list, I would prefer if you replaced the
\iffalse ... \fi with a higher-level command, namely \begin{comment} ...
\end{comment} (from the `comment' package).  First of all, this syntax
suits LaTeX better since it resembles normal environments.  Second, it
is a bad idea in general to expose \ifXXX to the top level; in other
words, users should never do that.  Reason is that \ifXXX is handled
very special in TeX since you can define, say, \ifFoo which also pairs
with the next \fi, making correct balancing of nested \ifXXX commands
quite delicate and very hard to debug.

http://codereview.appspot.com/6584073/