Re: New bar line interface: include whichBar in convert-ly rule for bar line changes (issue 6695046)

[marc]

Reviewers: janek,

Message:
On 2012/10/21 16:46:36, janek wrote:
> Was it not for Graham Percival, to whom i dedicate all my code
reviews, i would
> have not find enough willpower to write a review!
> (seriously!)
> :)

> So, Marc, the problem is that convert-ly rule didn't convert commands
involving
> whicBar context property?  Like, \set Staff.whichBar = \"|:\" should
be
> converted to set Staff.whichBar = \".|:\"?

> If so, please write it a bit more explicitely in the commit message,
and
> reference Bar Line Interface's issue number and committish.  Other
than this,
> LGTM.

> cheers,
> Janek

OK, will do.

Description:
This is a follow-up of Issue 2790 and commit
cced43289cf170305e6e6517180659a1c4fa91db.

The whichBar property is not set explicitly anywhere
in the sources and thus was forgotten in the commit above.

Please review this at http://codereview.appspot.com/6695046/

Affected files:
  M python/convertrules.py
  M scm/define-context-properties.scm


Index: python/convertrules.py
diff --git a/python/convertrules.py b/python/convertrules.py
index  
6eeb392ee4feda35bcb118feb8fb0b960aaefdf8..5d44fd7a150c7fb33e241c247330ae754392ff4f  
100644
--- a/python/convertrules.py
+++ b/python/convertrules.py
@@ -3399,7 +3399,7 @@ def conv (str):
                   matcharg + ")", r"\\shape\2\1", str)
     return str

-barstring=r"(\\bar|defaultBarType|segnoType|doubleRepeatType| 
startRepeatType|endRepeatType|doubleRepeatSegnoType|startRepeatSegnoType| 
endRepeatSegnoType)(\s*[=]?\s*[#]?)"
+barstring=r"(\\bar|whichBar|defaultBarType|segnoType|doubleRepeatType| 
startRepeatType|endRepeatType|doubleRepeatSegnoType|startRepeatSegnoType| 
endRepeatSegnoType)(\s*[=]?\s*[#]?)"

 @rule ((2, 17, 5), r"New bar line interface")
 def conv(str):
Index: scm/define-context-properties.scm
diff --git a/scm/define-context-properties.scm  
b/scm/define-context-properties.scm
index  
c1c006cf06f0d347de07fdc5a0a3fb42bb4a13cd..76c5191bf1518b9a2e3e81eaefb274db877871d2  
100644
--- a/scm/define-context-properties.scm
+++ b/scm/define-context-properties.scm
@@ -576,7 +576,7 @@ of bar line to create.
 Example:

 @example
-\\set Staff.whichBar = \"|:\"
+\\set Staff.whichBar = \".|:\"
 @end example

 @noindent