lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Allow quoted identifiers like to be used like \"violin1", not just d


From: dak
Subject: Re: Allow quoted identifiers like to be used like \"violin1", not just defined. (issue 6778055)
Date: Sun, 28 Oct 2012 18:05:20 +0000

On 2012/10/28 17:38:10, Keith wrote:
http://codereview.appspot.com/6778055/diff/1/lily/lexer.ll
File lily/lexer.ll (right):

http://codereview.appspot.com/6778055/diff/1/lily/lexer.ll#newcode95
lily/lexer.ll:95: The inside of \"violin1" is marked by nesting two
quote modes
as we
A start-condition named "command_quote" would be less mysterious than
having
special meaning for "quote" within "quote".

That is, start-conditions <quote,command_quote> for scanning the
innards of
quotes, then
<command_quote> \" {/* pop one state and return the command */}

Well, code duplication.  Avoiding code duplication would mean having to
have a "command" mode to return to, just for executing the command and
popping and returning again.  I'll take a closed look at just how
complex the duplication would be.  Maybe it is not that bad.

http://codereview.appspot.com/6778055/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]