Re: Applies scheme indentation according to the GNU guidelines (issue 6814080)

[marc]

Reviewers: janek, dak, Graham Percival,

Message:
Looking a little closer through the bunch of lines,
this is far from being pushed.

(1) There are single ';' comments spread throughout
    various scheme files, and emacs doesn't like them.
    The best way to eliminate them is to manually replace
    them (I don't trust a script here) before running
    fixscm.sh

(2) Lists seem to be formatted as if the first entry were
    a function; is there a way to convince emacs to
    do this differently?




http://codereview.appspot.com/6814080/diff/1/scm/chord-entry.scm
File scm/chord-entry.scm (left):

http://codereview.appspot.com/6814080/diff/1/scm/chord-entry.scm#oldcode18
scm/chord-entry.scm:18: ; for define-safe-public when byte-compiling
using Guile V2
there are *a lot* of comments starting with just
a single ';' instead of ';;'.

I think a separate commit for just this issue should
be created? This means a lot of manual search&replace :-(

http://codereview.appspot.com/6814080/diff/1/scm/define-event-classes.scm
File scm/define-event-classes.scm (right):

http://codereview.appspot.com/6814080/diff/1/scm/define-event-classes.scm#newcode29
scm/define-event-classes.scm:29: arpeggio-event breathing-event
extender-event span-event
This is just ugly; how can I prevent emacs from doing this?

http://codereview.appspot.com/6814080/diff/1/scm/define-grob-interfaces.scm
File scm/define-grob-interfaces.scm (left):

http://codereview.appspot.com/6814080/diff/1/scm/define-grob-interfaces.scm#oldcode114
scm/define-grob-interfaces.scm:114: thickness))
This indentation is not correct IMHO.
How can emacs format a list accordingly?

http://codereview.appspot.com/6814080/diff/1/scm/define-grob-properties.scm
File scm/define-grob-properties.scm (right):

http://codereview.appspot.com/6814080/diff/1/scm/define-grob-properties.scm#newcode34
scm/define-grob-properties.scm:34: ;;
well, there is probably no easy way to convince
emacs not to indent this, but it looks not too bad, either...

http://codereview.appspot.com/6814080/diff/1/scm/define-music-types.scm
File scm/define-music-types.scm (left):

http://codereview.appspot.com/6814080/diff/1/scm/define-music-types.scm#oldcode19
scm/define-music-types.scm:19: ; for define-safe-public when
byte-compiling using Guile V2
... and some more spurious single ';' comments
malformatted.

Description:
Applies scheme indentation according to the GNU guidelines

This is the result of
scripts/auxiliar/fixscm.sh scm/*
with some manual tweaking in clip-region.scm where ';:'
instead of ';;' was used as a comment sign.

Please review this at http://codereview.appspot.com/6814080/

Affected files:
  M scm/auto-beam.scm
  M scm/autochange.scm
  M scm/backend-library.scm
  M scm/bar-line.scm
  M scm/bezier-tools.scm
  M scm/c++.scm
  M scm/chord-entry.scm
  M scm/chord-generic-names.scm
  M scm/chord-name.scm
  M scm/clip-region.scm
  M scm/coverage.scm
  M scm/define-context-properties.scm
  M scm/define-event-classes.scm
  M scm/define-grob-interfaces.scm
  M scm/define-grob-properties.scm
  M scm/define-grobs.scm
  M scm/define-markup-commands.scm
  M scm/define-music-callbacks.scm
  M scm/define-music-display-methods.scm
  M scm/define-music-properties.scm
  M scm/define-music-types.scm
  M scm/define-note-names.scm
  M scm/define-stencil-commands.scm
  M scm/define-woodwind-diagrams.scm
  M scm/display-lily.scm
  M scm/display-woodwind-diagrams.scm
  M scm/document-backend.scm
  M scm/document-context-mods.scm
  M scm/document-functions.scm
  M scm/document-identifiers.scm
  M scm/document-markup.scm
  M scm/document-music.scm
  M scm/document-translation.scm
  M scm/documentation-generate.scm
  M scm/documentation-lib.scm
  M scm/editor.scm
  M scm/encoding.scm
  M scm/file-cache.scm
  M scm/flag-styles.scm
  M scm/font.scm
  M scm/framework-eps.scm
  M scm/framework-null.scm
  M scm/framework-ps.scm
  M scm/framework-scm.scm
  M scm/framework-socket.scm
  M scm/framework-svg.scm
  M scm/fret-diagrams.scm
  M scm/graphviz.scm
  M scm/guile-debugger.scm
  M scm/harp-pedals.scm
  M scm/layout-beam.scm
  M scm/layout-slur.scm
  M scm/lily-library.scm
  M scm/lily-sort.scm
  M scm/lily.scm
  M scm/ly-syntax-constructors.scm
  M scm/markup-macros.scm
  M scm/markup.scm
  M scm/memory-trace.scm
  M scm/midi.scm
  M scm/modal-transforms.scm
  M scm/music-functions.scm
  M scm/output-lib.scm
  M scm/output-ps.scm
  M scm/output-socket.scm
  M scm/output-svg.scm
  M scm/page.scm
  M scm/paper-system.scm
  M scm/paper.scm
  M scm/parser-clef.scm
  M scm/parser-ly-from-scheme.scm
  M scm/part-combiner.scm
  M scm/predefined-fretboards.scm
  M scm/ps-to-png.scm
  M scm/safe-utility-defs.scm
  M scm/script.scm
  M scm/song-util.scm
  M scm/song.scm
  M scm/standalone.scm
  M scm/stencil.scm
  M scm/tablature.scm
  M scm/text.scm
  M scm/time-signature-settings.scm
  M scm/titling.scm
  M scm/to-xml.scm
  M scm/translation-functions.scm
  M scm/x11-color.scm