|
From: | thomasmorley65 |
Subject: | Re: Adds Ferneyhough hairpins to LilyPond. (issue 7615043) |
Date: | Mon, 11 Mar 2013 23:38:17 +0000 |
Hi Mike, sorry to have some more nit-picks. https://codereview.appspot.com/7615043/diff/15001/scm/output-lib.scm File scm/output-lib.scm (right): https://codereview.appspot.com/7615043/diff/15001/scm/output-lib.scm#newcode1051 scm/output-lib.scm:1051: 0.1 Hard-coded thickness. Why not multiply 'thickness-property from Hairpin and 'line-thickness as usual? https://codereview.appspot.com/7615043/diff/15001/scm/output-lib.scm#newcode1052 scm/output-lib.scm:1052: 1.0 I'd do the scaling here. ly:stencil-scale would be superfluous than. https://codereview.appspot.com/7615043/diff/15001/scm/output-lib.scm#newcode1077 scm/output-lib.scm:1077: (cons xtrans ytrans))) I'm not sure ytrans is needed. Setting it 0 seems to make no difference. Delete and use ly:stencil-translate-axis? https://codereview.appspot.com/7615043/
[Prev in Thread] | Current Thread | [Next in Thread] |