[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Make a PostEvents container class for packaging several postevents (
From: |
dak |
Subject: |
Re: Make a PostEvents container class for packaging several postevents (issue 7742044) |
Date: |
Sun, 24 Mar 2013 13:36:43 +0000 |
https://codereview.appspot.com/7742044/diff/5001/scm/define-music-types.scm
File scm/define-music-types.scm (right):
https://codereview.appspot.com/7742044/diff/5001/scm/define-music-types.scm#newcode77
scm/define-music-types.scm:77: \n(no direction specified), and where
@code{y} is an articulation\
On 2013/03/24 13:20:15, Ian Hulin (gmail) wrote:
"\n(no direction specified or @code{-}), and when @code{y} is an
articulation\"
I did not actually change this documentation string, only formatted it
differently to stop it from throwing the whole Emacs
indentation/highlighting engine off. And @code{-} _does_ not specify a
direction but merely is a syntactic marker not actually related to
ArticulationEvent itself.
The whole documentation string is only so-so accurate (for example, one
_can't_ have x = ^ and y "such as" -.) and the proposed change is more
or less from inaccurate to inaccurate without a real incremental
improvement.
Now this patch has already been committed and this change is a separate
commit "Defuse some open parens starting lines...". I don't consider it
worth reverting (and getting back the Emacs-confusing strings), but it
would certainly warrant a more accurate rewrite. The proposed change in
wording is not really an improvement, however.
https://codereview.appspot.com/7742044/